fix: EditDrawer correctly reads and labels unlisted privacy

- serve/server.py GET adds private:bool to the response (true when
  privacy is "unlisted" or legacy "private") so EditDrawer can read it
- edit/server.py GET: same fix for the single-user edit server
- EditDrawer: fall back to d.privacy if d.private is absent; rename
  "Private" toggle label to "Unlisted"
This commit is contained in:
Davide Scaini
2026-04-19 22:58:09 +02:00
parent 8a3e7831d3
commit 5227b30456
3 changed files with 10 additions and 4 deletions
+1 -1
View File
@@ -407,7 +407,7 @@ async def get_activity(activity_id: str) -> JSONResponse:
"gear": fm.get("gear", detail.get("gear") or ""), "gear": fm.get("gear", detail.get("gear") or ""),
"description": body or fm.get("description") or detail.get("description") or "", "description": body or fm.get("description") or detail.get("description") or "",
"highlight": fm.get("highlight", detail.get("custom", {}).get("highlight", False)), "highlight": fm.get("highlight", detail.get("custom", {}).get("highlight", False)),
"private": fm.get("private", detail.get("privacy") == "private"), "private": fm.get("private", detail.get("privacy") in ("private", "unlisted")),
"hide_stats": fm.get("hide_stats", detail.get("custom", {}).get("hide_stats", [])), "hide_stats": fm.get("hide_stats", detail.get("custom", {}).get("hide_stats", [])),
"images": images, "images": images,
}) })
+5 -1
View File
@@ -1236,7 +1236,11 @@ async def get_activity(
user = _require_user(bincio_session) user = _require_user(bincio_session)
_check_id(activity_id) _check_id(activity_id)
path = _require_owns(activity_id, user) path = _require_owns(activity_id, user)
return JSONResponse(json.loads(path.read_text())) detail = json.loads(path.read_text())
# Normalise for EditDrawer: add `private` bool so the drawer works regardless
# of whether the raw JSON uses the old "private" or the new "unlisted" value.
detail["private"] = detail.get("privacy") in ("private", "unlisted")
return JSONResponse(detail)
@app.post("/api/activity/{activity_id}", response_model=ActivityEditResponse) @app.post("/api/activity/{activity_id}", response_model=ActivityEditResponse)
+4 -2
View File
@@ -54,7 +54,9 @@
// Strip any auto-inserted image markdown refs — images are tracked via custom.images // Strip any auto-inserted image markdown refs — images are tracked via custom.images
description = (d.description ?? '').replace(/!\[[^\]]*\]\([^)]+\)\n?/g, '').trim(); description = (d.description ?? '').replace(/!\[[^\]]*\]\([^)]+\)\n?/g, '').trim();
highlight = d.highlight ?? false; highlight = d.highlight ?? false;
isPrivate = d.private ?? false; // d.private is a bool (from the API); d.privacy is the raw field on older
// endpoints. Accept either so the drawer works with both serve and edit servers.
isPrivate = d.private ?? (d.privacy === 'unlisted' || d.privacy === 'private') ?? false;
hideStats = d.hide_stats ?? []; hideStats = d.hide_stats ?? [];
images = d.images ?? []; images = d.images ?? [];
} catch (e: any) { } catch (e: any) {
@@ -286,7 +288,7 @@
style={isPrivate ? 'background:rgba(239,68,68,.1)' : ''} style={isPrivate ? 'background:rgba(239,68,68,.1)' : ''}
on:click={() => isPrivate = !isPrivate} on:click={() => isPrivate = !isPrivate}
> >
Private Unlisted
</button> </button>
</div> </div>
{/if} {/if}